Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user feedback and speed-up interlis import qgep #141

Merged
merged 19 commits into from
Jun 18, 2024

Conversation

sjib
Copy link
Contributor

@sjib sjib commented May 11, 2024

  • add messages in message bar
  • add messages to log
  • add Refresh materialized views
  • add main_cover function
  • add main_node function

Datamodel - see QGEP/datamodel@1c90791

  • add main_cover function
  • add main_node function

@sjib
Copy link
Contributor Author

sjib commented May 11, 2024

Should improve (I have added some logger info that it is still processing) #119 - not yet best user experience, but already better

@sjib sjib marked this pull request as draft May 11, 2024 20:22
@sjib sjib added the enhancement New feature or request label May 11, 2024
@sjib
Copy link
Contributor Author

sjib commented May 13, 2024

import_krattigen_dss_003_12052024_215355

It looks like the triggers are re-enable before the data is imported - the wizard is still open - see logging on screen shot.

@domi4484 Is this a similar error as you have found in TEKSI wastewater? https://github.com/teksi/wastewater/pull/211/files

How could the TEKSI improvment be backported to qgep?

@domi4484
Copy link
Collaborator

@sjib Yes it seems similar. Basically you need to re-enable the triggers only after the dialog has been acceptedd/rejected.

By re-thinking on this we could have an issue (in TEKSI as well) if someone kills QGIS before the trigger are re-enabled they will remain disabled forever.
Maybe we should add a check on startup of the plugin or some other mechanism to check if the trigger are enabled

This speeds up the import greatly!
@sjib sjib self-assigned this May 31, 2024
@sjib
Copy link
Contributor Author

sjib commented May 31, 2024

  • Changed all post-processing to extra function qgep_postimport

With that the triggers are enabled after the import - this speeds up the import greatly (e.g. Testdata K from @urskaufmann in 3 minutes instead of 30 minutes or more).

This needs these datamodel changes 1.6.2 to work properly!

@sjib sjib requested review from domi4484 and ponceta May 31, 2024 14:58
@sjib sjib marked this pull request as ready for review May 31, 2024 14:59
@sjib
Copy link
Contributor Author

sjib commented May 31, 2024

By re-thinking on this we could have an issue (in TEKSI as well) if someone kills QGIS before the trigger are re-enabled they will remain disabled forever.
@domi4484 Glad to have you're review on my work - may be you can add your suggestions for this also in this.

@sjib sjib changed the title Improve user feedback while importing data in qgep Improve user feedback and speed-up interlis import qgep May 31, 2024
@sjib sjib added this to the 1.6.2 - 2024.1 milestone May 31, 2024
qgepqwat2ili/gui/gui_import.py Outdated Show resolved Hide resolved
qgepqwat2ili/gui/gui_import.py Show resolved Hide resolved
qgepqwat2ili/postimport.py Outdated Show resolved Hide resolved
qgepqwat2ili/qgep/import_.py Outdated Show resolved Hide resolved
@sjib
Copy link
Contributor Author

sjib commented Jun 17, 2024

@ponceta Ready for review and then merging - needs these QGEP/datamodel#235 to work properly!

@ponceta ponceta closed this Jun 18, 2024
@ponceta ponceta reopened this Jun 18, 2024
@ponceta ponceta merged commit 9c28c0e into master Jun 18, 2024
8 checks passed
@ponceta ponceta deleted the 2024-05-11-import-improve-progress-messages branch June 18, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants